Skip to content

[PM-41949] Enhance SecretsManagerSubscribeComponent with feature flag support - #22412

Open
JaredScar wants to merge 1 commit into
mainfrom
ac/pm-41949-more-from-bitwarden-using-old-terminology
Open

[PM-41949] Enhance SecretsManagerSubscribeComponent with feature flag support#22412
JaredScar wants to merge 1 commit into
mainfrom
ac/pm-41949-more-from-bitwarden-using-old-terminology

Conversation

@JaredScar

@JaredScar JaredScar commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-41949

📔 Objective

Fixes up terminology on billing screen for new organization to match VFO 1 terminology copy

📸 Screenshots

image

@JaredScar
Enhance SecretsManagerSubscribeComponent with feature flag support
73277ee 
- Introduced a new feature flag for VFO1Foundation in the SecretsManagerSubscribeComponent.
- Updated the plan name display logic to conditionally show "Free plan with shared vault" based on the feature flag.
- Added corresponding i18n key for the new plan name in the localization messages.
@JaredScar
JaredScar requested a review from a team as a code owner August 13, 2026 19:37
@JaredScar JaredScar added ai-review Request a Claude code review t:feature Change Type - Feature Development labels Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a feature-flagged copy change in SecretsManagerSubscribeComponent that swaps the free-tier plan name to VFO1 terminology, plus the new freePlanWithSharedVault string in the English locale file. Verified the toSignal field initializer safely resolves the injected ConfigService under this repo's useDefineForClassFields: false setting, that free2PersonOrganization has no other consumers, and that the existing organization-plans.component.spec.ts already mocks both the child component and ConfigService. No security, correctness, or breaking-change concerns found.

Code Review Details

No findings.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.85%. Comparing base (772f82d) to head (73277ee).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...b/src/app/billing/shared/sm-subscribe.component.ts 42.85% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #22412      +/-   ##
==========================================
+ Coverage   53.75%   53.85%   +0.10%     
==========================================
  Files        4293     4293              
  Lines      136321   136329       +8     
  Branches    21546    21547       +1     
==========================================
+ Hits        73275    73418     +143     
+ Misses      57684    57549     -135     
  Partials     5362     5362

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbrown-livefront sbrown-livefront Awaiting requested review from sbrown-livefront sbrown-livefront is a code owner automatically assigned from bitwarden/team-billing-dev

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ai-review Request a Claude code review t:feature Change Type - Feature Development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JaredScar